Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed "exact match boost" implementation to use a match_phrase query in should #4975

Closed
wants to merge 13 commits into from
Closed

Changed "exact match boost" implementation to use a match_phrase query in should #4975

wants to merge 13 commits into from

Conversation

dryruffian
Copy link
Contributor

@dryruffian dryruffian commented Sep 23, 2024 •
edited
Loading

Fixes

Fixes #4960 by @sarayourfriend

Description

This PR changes the simple_query_string query for boosting exact matches on the title to a match_phrase query, as suggested by @sarayourfriend. This change will save some parsing cycles in Elasticsearch and make our intention much clearer in code and in the generated query. I have also removed quotes_stripped variable as its not needed anymore.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

dryruffian and others added 12 commits September 22, 2024 23:11
@dryruffian
Add utori to the "Made with Openverse" page
71e8ff5 
dd Sutori to the "Made with Openverse" page.
@dryruffian
Add Sutori to the "Made with Openverse" page.
107fdbd
@dryruffian
Add Sutori to Made with Openverse page (#4972)
fc997ea 
Fixed commit message to be more precise and include the issue number
@dryruffian
Add Sutori to Made with Openverse page (#4972)
6b2f8db 
Fixed commit message to be more precise and include the issue number
@dryruffian
Add Sutori to Made with Openverse page (#4972)
6737693
@dryruffian
Merge branch 'main' of https://github.com/dryruffian/openverse
d37d2bd
@dryruffian
Add Sutori to Made with Openverse page (#4972)
5906ab7
@dryruffian @sarayourfriend
@dryruffiaAdd Sutori to Made with Openverse page (#4972)
8bfa386 
I added the suggestion from @sarayourfriend.

Co-authored-by: sarayourfriend <[email protected]>
@dryruffian
Add Sutori to Made with Openverse page (#4971)
37650d2
@dryruffian
Merge branch 'main' of https://github.com/dryruffian/openverse
211940b
@dryruffian
Merge branch 'WordPress:main' into main
cf225ff
@dryruffian
Change "exact match boost" implementation to use a match_phrase query…
409a45c 
… in should #4960

I have added support for "match_pharse"
and also removed variable quotes_stripped it's not needed now.
@dryruffian dryruffian requested a review from a team as a code owner September 23, 2024 16:34
@dryruffian dryruffian requested review from krysal and sarayourfriend and removed request for a team September 23, 2024 16:34
@openverse-bot openverse-bot added 🧱 stack: api Related to the Django API 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Sep 23, 2024
@dryruffian
Changed exact match boost implementation to use a match_phrase query …
3cade36 
…in should #4960

I have added support for "match_pharse"
and also removed variable quotes_stripped it's not needed now.
@dryruffian dryruffian marked this pull request as draft September 23, 2024 17:04
@dryruffian dryruffian closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krysal krysal Awaiting requested review from krysal krysal is a code owner automatically assigned from WordPress/openverse-api

@sarayourfriend sarayourfriend Awaiting requested review from sarayourfriend sarayourfriend is a code owner automatically assigned from WordPress/openverse-api

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change "exact match boost" implementation to use a match_phrase query in should
2 participants
@dryruffian @openverse-bot